Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect client retransmissions #676

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix incorrect client retransmissions #676

merged 1 commit into from
Oct 6, 2024

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Oct 6, 2024

introduced by ec76652. If Client has gone to finished we know that server sent Finished. No reason to ever re-send messages.

Resolves pion/webrtc#2909

introduced by ec76652. If Client has gone to finished we know that
server sent Finished. No reason to ever re-send messages.

Resolves pion/webrtc#2909
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (d7f5fee) to head (fa297e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   80.15%   80.16%   +0.01%     
==========================================
  Files         101      101              
  Lines        5371     5374       +3     
==========================================
+ Hits         4305     4308       +3     
  Misses        696      696              
  Partials      370      370              
Flag Coverage Δ
go 80.19% <100.00%> (+0.01%) ⬆️
wasm 64.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 98a05d6 into master Oct 6, 2024
16 checks passed
@Sean-Der Sean-Der deleted the bad-client-rtx branch October 6, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer connection closes immediately after opening detached data channel on v4.0.0-beta.25 or newer
1 participant